Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting of SonarQube module key bindings by applying a pattern #15

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Allow setting of SonarQube module key bindings by applying a pattern #15

merged 1 commit into from
Dec 20, 2024

Conversation

swesteme
Copy link
Collaborator

A new SonarLintHandler has been added, allowing a module name pattern matching to set a SonarQube project key.

Example autoconfigSonarLint.yaml:

bindings: 
  - modulePattern: base-module-name-.*
    projectKey: module-sonarqube-project

Closes #8

@swesteme swesteme linked an issue Nov 18, 2024 that may be closed by this pull request
Feature SonarQube Binding Configuration in Multi-Project setup #8
Closed
@swesteme swesteme requested a review from nailujx86 November 18, 2024 10:21
nailujx86
nailujx86 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@nailujx86 nailujx86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog and version bump are missing.

src/main/java/de/gebit/plugins/autoconfig/handlers/sonarlint/SonarLintHandler.java Outdated Show resolved Hide resolved
src/main/java/de/gebit/plugins/autoconfig/AutoconfigStartup.java Outdated Show resolved Hide resolved
@swesteme swesteme force-pushed the 8-feature-sonarqube-binding-configuration-in-multi-project-setup branch 2 times, most recently from 50eee31 to 82fb32f Compare December 20, 2024 15:57
@swesteme swesteme force-pushed the 8-feature-sonarqube-binding-configuration-in-multi-project-setup branch from 82fb32f to bb9d553 Compare December 20, 2024 16:01
@swesteme swesteme merged commit d9cfde5 into main Dec 20, 2024
1 check passed
@swesteme swesteme deleted the 8-feature-sonarqube-binding-configuration-in-multi-project-setup branch December 20, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nailujx86 nailujx86 nailujx86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature SonarQube Binding Configuration in Multi-Project setup
2 participants
@swesteme @nailujx86